AdGuard 5.10 second beta version release

[Rian]

Nope i haven't enables it when the problem happened

Here it shows its disabled

Here its ticked

 

[streetwolf]

Fanboy's Annoyance List is causing non-ad stuff from being displayed at www.howtogeek.com. This list works fine with ABP. I know you do some reformatting of these lists so I wonder if some filter is being incorrectly changed. The whole left side is missing which are just a list of articles with a graphic for each. They are not ads of any kind.

 

[Boo Berry]

Filtering enabled breaks https://www.yahoo.com/

Anyone else confirm?

EDIT: Error in the detailed logs about https://www.yahoo.com/;

Error processing the request:
System.ArgumentOutOfRangeException: Index and length must refer to a location within the string.
Parameter name: length
Source: mscorlib
Stack trace:    at System.String.Substring(Int32 startIndex, Int32 length)
   at Adguard.Filter.Rules.ShortcutsLookupTable.LookupRules(String url)
   at Adguard.Filter.Rules.UrlFilter.IsFiltered(String url, String referrer, Boolean isAjaRequest, Boolean isSubdocument, Boolean isObjectSubrequest)
   at Adguard.Filter.RequestFilter.InnerFilterHttpRequest(String requestUrl, String referrer, FilteringContext filteringContext, Boolean isAjaRequest, Boolean isSubdocument, Boolean isObjectSubrequest)
   at Adguard.Filter.RequestFilter.CheckCollapseRules(HtmlElement element, FilteringContext context)
   at Adguard.Filter.RequestFilter.FilterElement(HtmlElement element, FilteringContext context)
   at Adguard.Filter.Parser.ContentEditor.CheckRemovedRange(HtmlElement element)
   at Adguard.Html.ContentEditingHtmlParser.OnEndElement(HtmlElement element, ParsingContext context)
   at Adguard.Html.HtmlParser.OnStartTagFound(HtmlElement element, Tag endTag, ParsingContext context)
   at Adguard.Html.HtmlParser.ProcessEndTag(Tag tag, ParsingContext context)
   at Adguard.Html.HtmlParser.ParseTags(ParsingContext context)
   at Adguard.Html.HtmlParser.Parse(ParsingContext context)
   at Adguard.Filter.Http.HttpResponseFilter.FilterPage(FilteringContext filteringContext, HttpRequest request, Encoding pageEncoding, PeekingStream inputStream, Stream responseStream)
   at Adguard.Filter.Http.HttpResponseFilter.FilterChunkedResponse(FilteringContext filteringContext, HttpRequest request, HttpResponse response, Encoding pageEncoding, PeekingStream inputStream, Stream responseStream)
   at Adguard.Filter.Http.HttpResponseFilter.FilterHtmlResponse(HttpRequest request, HttpResponse response, Stream responseStream, FilteringContext filteringContext)
   at Adguard.Filter.Http.HttpResponseFilter.FilterResponse(HttpRequest request, HttpResponse response, Stream responseStream, FilteringContext filteringContext)
   at Adguard.Network.Filter.HttpFilter.ProcessRequest(HttpRequest request, FilteringContext filteringContext, RecordingStream remoteRecordingStream)
   at Adguard.Network.Filter.HttpFilter.ProcessConnection(RecordingStream localRecordingStream, RecordingStream remoteRecordingStream)
   at Adguard.Network.Filter.HttpFilter.Filter()

---------- Post added at 06:14 PM ---------- Previous post was at 05:29 PM ----------

Adguard is crashing at random when trying to edit/add user rules manually (via copy and paste) to the user filter. I can reproduce it with the following steps (probably a good idea to have multiple rules in the list).

1) Double click rule in user filter to bring up the editing function for the rule then click on another rule to exit editing.
2) Single click or slow double click on another rule and it'll crash.

 

[streetwolf]

The log file I assume is the one within Adguard itself, not the one in the ProgramData folder. In any case, the only error I see is an entry that says error followed by the URL of Yahoo. I don't see what you provided above.

As far as the crash I followed your instructions and couldn't get a crash. But I then clicked on another entry and AG did crash. So perhaps the STR is different at times.

Here's the crash taken from my Event Log. Event ID: 1026

Application: Adguard.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ArgumentException
Stack:
at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)
at MS.Win32.UnsafeNativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef)
at System.Windows.Threading.Dispatcher.PushFrameImpl(System.Windows.Threading.DispatcherFrame)
at System.Windows.Threading.Dispatcher.PushFrame(System.Windows.Threading.DispatcherFrame)
at System.Windows.Threading.Dispatcher.Run()
at System.Windows.Application.RunDispatcher(System.Object)
at System.Windows.Application.RunInternal(System.Windows.Window)
at System.Windows.Application.Run(System.Windows.Window)
at Adguard.App.Main()

---------- Post added at 10:09 PM ---------- Previous post was at 08:45 PM ----------

Also, if I delete a filter then delete another filter I get this error in Event Log (1000). A workaround is to close the AG windows after each delete and then reopen it and delete the next filter.

Faulting application name: Adguard.exe, version: 5.10.1128.5771, time stamp: 0x53beffc6
Faulting module name: KERNELBASE.dll, version: 6.3.9600.17055, time stamp: 0x532943a3
Exception code: 0xe0434352
Fault offset: 0x00011d4d
Faulting process id: 0x10fc
Faulting application start time: 0x01cf9d7349314558
Faulting application path: C:\Program Files (x86)\Adguard\Adguard.exe
Faulting module path: C:\Windows\SYSTEM32\KERNELBASE.dll
Report Id: d7c48797-0967-11e4-8394-c86000a0a026
Faulting package full name:
Faulting package-relative application ID:

 

[Boo Berry]

So perhaps the STR is different at times.

Yup, I can reproduce it that way too consistently plus I get the same exact errors in my event log.

 

[Rian]

Today when i started my system it shows that the database is not loaded

After a manual update it was back to normal but still i though i should report it

 

[l0rdraiden]

I have notice that the I/O consumption is higher or similar to any AV, it would be possible to avoid this by using more RAM therefore having less access to the disk?
I guess the impact would be insignificant but I high I/O could be bad for an SSD.

I have notice as well that ublock and ghostery still blocks google analytics, why this isn't blocked by adguard? I have the filter for useful ads disable and I have included the easy lists.

BUG: while using feedly, when I click on an article it gets stuck in the redirection, when I disable adblock, it works fine. It's because of the easylists but It doesn't happens when I use other adblocker, so it must be a bug in adguard.

The default block list of adguard, english filter, spyware filter... on which lists are based this ones? are better than Easylist and Easylist privacy? are the easylists included? is there overlap?

Could you use the source of ublock to improve adguard? https://github.com/gorhill/uBlock
https://github.com/gorhill/uBlock/wiki/µBlock-vs.-ABP:-efficiency-compared

A few more lists below that could be added specially the ones related with malware.
 Long-lived malware domains (malwaredomains.com): 2,199 used out of 2,204
 Malware domains (malwaredomains.com): 11,475 used out of 13,799
 Peter Lowe’s Ad server list (yoyo.org): 0 used out of 2,483
 Malware Domain List (malwaredomainlist.com): 1,348 used out of 1,348
 hpHosts’s Ad and tracking servers (hosts-file.net): 0 used out of ?
 Dan Pollock’s hosts file (someonewhocares.org): 0 used out of ?
 MVPS HOSTS (mvps.org): 0 used out of 13,591
 Spam404 (spam404bl.com): 0 used out of ?
 EasyList (adblockplus.org): 17,140 used out of 17,375
 EasyList without element hiding rules (adblockplus.org): 0 used out of ?
 EasyPrivacy (adblockplus.org): 9,090 used out of 9,093
 Fanboy’s Annoyance List (adblockplus.org): 0 used out of ?
 Fanboy’s Enhanced Tracking List (fanboy.co.nz): 0 used out of ?
 Fanboy’s Anti-Facebook (see warning inside list) (fanboy.co.nz): 0 used out of ?
 Anti-Adblock Killer | Filters for Adblockers (raw.githubusercontent.com): 236 used out of 236
 EasyList Germany (adblockplus.org): 0 used out of ?
 EasyList Italy (adblockplus.org): 0 used out of ?
 EasyList Dutch (adblockplus.org): 0 used out of ?
 EasyList Liste FR (adblockplus.org): 0 used out of ?
 EasyList RU AdList (дополнение к EasyList) (adblockplus.org): 0 used out of ?
 EasyList China (中文) (adblockplus.org): 0 used out of ?
 cjxlist (main focus on Chinese sites) (cjxlist1.googlecode.com): 0 used out of ?
 EasyList China (obsolete: to be removed) (adblock-chinalist.googlecode.com): 0 used out of ?
 ABP Japanese filters (の日本用フィルタ) (adblock-plus-japanese-filter.googlecode.com): 0 used out of ?
 Adblock Plus Lithuania (margevicius.lt): 0 used out of ?
 Bulgarian Adblock list (stanev.org): 0 used out of ?
 ABPindo (indonesianadblockrules.googlecode.com): 0 used out of ?
 Liste AR (liste-ar-adblock.googlecode.com): 0 used out of ?
 EasyList Czech and Slovak (raw.githubusercontent.com): 0 used out of ?
 Adblock Polska (raw.githubusercontent.com): 0 used out of ?
 EasyList Hebrew (raw.githubusercontent.com): 0 used out of ?
 Wiltteri (wiltteri.net): 0 used out of ?
 Norsk adblockliste (norsk) (fredfiber.no): 0 used out of ?
 Fanboy's Swedish (fanboy.co.nz): 0 used out of ?
 Icelandic ABP List (islenska) (gardar.net): 0 used out of ?
 Schacks Adblock Plus liste (dansk) (schack.dk): 0 used out of ?
 Greek AdBlock Filter (void.gr): 0 used out of ?
 Filtros Nauscopicos (mozilla-hispano.org): 3,684 used out of 3,684
 hufilter (magyar) (hufilter.hu): 0 used out of ?
 ABP X Files (dropboxusercontent.com): 0 used out of ?

 

[streetwolf]

I've been getting pages that will not load due to one filter or another. For example have the spyware filter enabled and go to http://thewilshiregrandhote-px.rtrk.com/hospice-service-dog.html

The throbber spins and spins forever without loading the page. Disable the Spyware filter and it loads.

This kind of behavior is not uncommon with this beta.

 

[Nameless]

Hmm odd, page loaded instantly first time then every time after it was stuck in the loading state like you said.

I then disabled a filter and reloaded it to see the response.

Easylist: Still didnt load the page
Easyprivacy: Still didnt load the page
FanboyAnnoyance: Still didnt load the page
Malwaredomains: Loaded the page

I then re-enabled them all tried the linka nd it failed again, i then disabled malwaredomains and.. page loaded.

I dont know what other additional filters you have so maybe there is some conflict? I just added malware to try it out, easylist, privacy and annoyance are the main ones i wanted. =)

 

[Boo Berry]

I'm beginning to notice continuous loading too with just using the English filter on sites like Discogs and even the Adguard account login page on the main site.

EDIT: It just happened loading the Quality Control section of the forums - it's just stuck in the loading state according to the circle animation on the tab in Chrome.

 

[rickyoh]

page half loading in Google on occasion can reliably cause it to do so by searching for "trans" (no quotes)

Spoiler

 

[Nameless]

Ive not had any issues yet :/

Well other than ones reported and i checked (streetwolf) though i will admit im about to post one issue but its a confirmation to see if its one my filters.
As for discogs loaded fine my end, and i wish [people would stop reminding me to sell my records - .- lol

@rickho had this once when searching fora game, can not even remember the name of the game as it was on extratorrent and its not on the list no more agh. (thought it was my connection playing up)

 

[Boo Berry]

Force updating the English filter seems to disable the filter list (ads appear on sites) until you disable and re-enable the English filter.

 

[Rian]

observed that sometimes pages seem to be continuously loading

 

[Boo Berry]

Error in the detailed logs on eBay;

The request was sent from the following web page:
http://www.ebay.com/sch/i.html?_trksid=p2050601.m570.l1313.TR0.TRC0.H0.Xcalling+all+stations+vinyl&_nkw=calling+all+stations+vinyl&_sacat=0&_from=R40

Error processing the request:
System.ArgumentOutOfRangeException: Index and length must refer to a location within the string.
Parameter name: length
Source: mscorlib
Stack trace:    at System.String.Substring(Int32 startIndex, Int32 length)
   at Adguard.Filter.Rules.ShortcutsLookupTable.LookupRules(String url)
   at Adguard.Filter.Rules.UrlFilter.IsFiltered(String url, String referrer, Boolean isAjaRequest, Boolean isSubdocument, Boolean isObjectSubrequest)
   at Adguard.Filter.RequestFilter.InnerFilterHttpRequest(String requestUrl, String referrer, FilteringContext filteringContext, Boolean isAjaRequest, Boolean isSubdocument, Boolean isObjectSubrequest)
   at Adguard.Filter.RequestFilter.CheckCollapseRules(HtmlElement element, FilteringContext context)
   at Adguard.Filter.RequestFilter.FilterElement(HtmlElement element, FilteringContext context)
   at Adguard.Filter.Parser.ContentEditor.CheckRemovedRange(HtmlElement element)
   at Adguard.Html.ContentEditingHtmlParser.OnEndElement(HtmlElement element, ParsingContext context)
   at Adguard.Html.HtmlParser.OnStartTagFound(HtmlElement element, Tag endTag, ParsingContext context)
   at Adguard.Html.HtmlParser.ProcessEndTag(Tag tag, ParsingContext context)
   at Adguard.Html.HtmlParser.ParseTags(ParsingContext context)
   at Adguard.Html.HtmlParser.Parse(ParsingContext context)
   at Adguard.Filter.Http.HttpResponseFilter.FilterPage(FilteringContext filteringContext, HttpRequest request, Encoding pageEncoding, PeekingStream inputStream, Stream responseStream)
   at Adguard.Filter.Http.HttpResponseFilter.FilterChunkedResponse(FilteringContext filteringContext, HttpRequest request, HttpResponse response, Encoding pageEncoding, PeekingStream inputStream, Stream responseStream)
   at Adguard.Filter.Http.HttpResponseFilter.FilterHtmlResponse(HttpRequest request, HttpResponse response, Stream responseStream, FilteringContext filteringContext)
   at Adguard.Filter.Http.HttpResponseFilter.FilterResponse(HttpRequest request, HttpResponse response, Stream responseStream, FilteringContext filteringContext)
   at Adguard.Network.Filter.HttpFilter.ProcessRequest(HttpRequest request, FilteringContext filteringContext, RecordingStream remoteRecordingStream)
   at Adguard.Network.Filter.HttpFilter.ProcessConnection(RecordingStream localRecordingStream, RecordingStream remoteRecordingStream)
   at Adguard.Network.Filter.HttpFilter.Filter()



New element hiding rules have been added to the page
Popup blocking code has been added to the page

Bytes received: 14420
Bytes sent: 3089

 

[Rian]

Tried the latest version of Adguard extension with the latest Beta of Adguard for windows. i noticed that when you block element using extension the rule is not added to Adguard for windows user filter but to the extension only

 

[Boo Berry]

Error in the detailed logs when trying to use Google Search;

The request was sent from the following web page:
https://www.google.com/

The following rule exception was activated:
@@//www.google.*/search$urlblock

Error processing the request:
System.ArgumentOutOfRangeException: Index and length must refer to a location within the string.
Parameter name: length
Source: mscorlib
Stack trace:    at System.String.Substring(Int32 startIndex, Int32 length)
   at Adguard.Filter.Rules.ShortcutsLookupTable.LookupRules(String url)
   at Adguard.Filter.Rules.UrlFilter.IsFiltered(String url, String referrer, Boolean isAjaRequest, Boolean isSubdocument, Boolean isObjectSubrequest)
   at Adguard.Filter.RequestFilter.InnerFilterHttpRequest(String requestUrl, String referrer, FilteringContext filteringContext, Boolean isAjaRequest, Boolean isSubdocument, Boolean isObjectSubrequest)
   at Adguard.Filter.RequestFilter.CheckCollapseRules(HtmlElement element, FilteringContext context)
   at Adguard.Filter.RequestFilter.FilterElement(HtmlElement element, FilteringContext context)
   at Adguard.Filter.Parser.ContentEditor.CheckRemovedRange(HtmlElement element)
   at Adguard.Html.ContentEditingHtmlParser.OnEndElement(HtmlElement element, ParsingContext context)
   at Adguard.Html.HtmlParser.OnStartTagFound(HtmlElement element, Tag endTag, ParsingContext context)
   at Adguard.Html.HtmlParser.ProcessEndTag(Tag tag, ParsingContext context)
   at Adguard.Html.HtmlParser.ParseTags(ParsingContext context)
   at Adguard.Html.HtmlParser.Parse(ParsingContext context)
   at Adguard.Filter.Http.HttpResponseFilter.FilterPage(FilteringContext filteringContext, HttpRequest request, Encoding pageEncoding, PeekingStream inputStream, Stream responseStream)
   at Adguard.Filter.Http.HttpResponseFilter.FilterChunkedResponse(FilteringContext filteringContext, HttpRequest request, HttpResponse response, Encoding pageEncoding, PeekingStream inputStream, Stream responseStream)
   at Adguard.Filter.Http.HttpResponseFilter.FilterHtmlResponse(HttpRequest request, HttpResponse response, Stream responseStream, FilteringContext filteringContext)
   at Adguard.Filter.Http.HttpResponseFilter.FilterResponse(HttpRequest request, HttpResponse response, Stream responseStream, FilteringContext filteringContext)
   at Adguard.Network.Filter.HttpFilter.ProcessRequest(HttpRequest request, FilteringContext filteringContext, RecordingStream remoteRecordingStream)
   at Adguard.Network.Filter.HttpFilter.ProcessConnection(RecordingStream localRecordingStream, RecordingStream remoteRecordingStream)
   at Adguard.Network.Filter.HttpFilter.Filter()



New element hiding rules have been added to the page
Popup blocking code has been added to the page

Bytes received: 80860
Bytes sent: 1739

 

[avatar]

Fanboy's Annoyance List is causing non-ad stuff from being displayed at www.howtogeek.com. This list works fine with ABP. I know you do some reformatting of these lists so I wonder if some filter is being incorrectly changed. The whole left side is missing which are just a list of articles with a graphic for each. They are not ads of any kind.

Thanks, I'll take a look today.

---------- Post added at 10:30 AM ---------- Previous post was at 10:25 AM ----------

I am pretty sure that continuous page load caused by the error you've found before:
System.ArgumentOutOfRangeException

---------- Post added at 10:31 AM ---------- Previous post was at 10:30 AM ----------

We'll fix all major bugs in todays beta, will be here in a couple of hours.

---------- Post added at 10:45 AM ---------- Previous post was at 10:31 AM ----------

I have notice that the I/O consumption is higher or similar to any AV, it would be possible to avoid this by using more RAM therefore having less access to the disk?
I guess the impact would be insignificant but I high I/O could be bad for an SSD.

How do you measure IO?

I have notice as well that ublock and ghostery still blocks google analytics, why this isn't blocked by adguard? I have the filter for useful ads disable and I have included the easy lists.

It's ok. Browser extensions do the request blocking before Adguard (they are working inside the browser after all).
If you disable Ghostery/uBlock, Adguard will block these requests.

BUG: while using feedly, when I click on an article it gets stuck in the redirection, when I disable adblock, it works fine. It's because of the easylists but It doesn't happens when I use other adblocker, so it must be a bug in adguard.

Check it again after today's beta please.

The default block list of adguard, english filter, spyware filter... on which lists are based this ones? are better than Easylist and Easylist privacy? are the easylists included? is there overlap?

In any case I do not recommend to use EasyList filters if there is a corresponding Adguard filter.
Exception is Fanboy's Annoyances and Social Blocking List, they are pretty good.

---------- Post added at 10:47 AM ---------- Previous post was at 10:45 AM ----------

Tried the latest version of Adguard extension with the latest Beta of Adguard for windows. i noticed that when you block element using extension the rule is not added to Adguard for windows user filter but to the extension only

Thank you for reporting it! One more major bug

 

[avatar]

Next beta is ready. Version 5.10.1136.5808.

Fixed:

* The situation when UI hangs in "Preparing to launch" screen
* Random crashes on user filters edit
* Added SSL exceptions setting
* Added userscripts validation on install
* Added "Reload" option to every userscript
* Fixed HTTP DELETE requests
* Google SafeBrowisng removed from application

 

[Boo Berry]

So far, so good. I've also added the following domains to the SSL exceptions;

drive.google.com
github.com
docs.googleusercontent.com
sites.google.com

Think these will have any false positives?

---------- Post added at 02:40 PM ---------- Previous post was at 01:53 PM ----------

Okay, still getting Filter databases have not been loaded messages.