[AdGuard for Windows] v6.2.432 RC

Status
Not open for further replies.

Blaz

Moderator & Translator
Staff member
Moderator
Huh, it's hot here. Nope, was replying to you actually.
I mentioned a useful element. Also just add an option to have back the old filtering log and I'm happy. You don't even have to improve the old filtering log, it was perfect for me and not so cluttered like the beta's filtering log.
 

avatar

Administrator
Staff member
Administrator
User could previously select the request, manually highlighting the items he wanted and copy.
This will be addressed in the next beta, we do hear you guys.

Also that new pane is not even resizable.
It is resizeable and closeable:
https://monosnap.com/file/2dyFY9H1MEE29UeiHLXiVxj9EZoTMy

Why did you make a change which can't even be disabled in the first place for people who hate that new behaviour.
Because filtering log is not just for copying request URLs. HTTP headers, content preview, network properties, that is often required to make a decision about the request.
 
Filed a feature request, should be relatively easy to implement:
https://github.com/AdguardTeam/AdguardForWindows/issues/1667
Not just values in the the details pane, thought.

Allow us to select multiple lines inside the filtering log as well and let us copy the request URLs from there! Just standard Windows behavior of this sort of list: Ctrl and Shift (and possibly Ctrl+A) for selecting multiple lines, right click and Ctrl+C to copy. That would solve 90% of the problem caused by not having a save/export function.
 
And just to go against Blaz here: I don't think maintaining two different versions of the filtering log is feasible. And "give me the old version" options inside software are almost always terrible and usually give the user a choice between two half-assed versions of the same thing with no real way to see what's better suited to them. Better improve the new version to work at least as well if not better than the old instead.

I really like the new filtering log, it makes a lot of things simpler and easier. Once you can easily copy and export stuff out of it it should make more advanced users (or simply those seeking for help) much, much happier.
 

avatar

Administrator
Staff member
Administrator
Allow us to select multiple lines inside the filtering log as well and let us copy the request URLs from there! Just standard Windows behavior of this sort of list: Ctrl and Shift (and possibly Ctrl+A) for selecting multiple lines, right click and Ctrl+C to copy. That would solve 90% of the problem caused by not having a save/export function.
This is not a standard pattern for the grid views like that.

Doable things:
1. Right-click on a record brings up a context menu with "Copy record", "Block/unblock request...", "Open in browser", "Copy URL", "Copy source URL", "Copy rule text", "Copy process name", "Save record..."
2. (That one is quite hard) Allow changing details pane position, let you choose between a sidebar position and a "bottom" position.

What for Ctrl+A, we will add export/import functions, it is a nice thing to have from the support POV.
 

avatar

Administrator
Staff member
Administrator
@Blaz what are your thoughts on the context menu thing? Yeah, it is not the same thing as the old small details panel, but it should partly cover your needs.

And one more thing worth noticing. Even if you don't want to add rules to the user filter, "new rule" dialog is a really convenient thing for building the rule text. Just copy/paste it from there and you're good.

One more thing @Alex302 was requesting a long time ago:
https://github.com/AdguardTeam/AdguardForWindows/issues/1669
 
This is not a standard pattern for the grid views like that.
Well, it's standard behavior for that type of content and for your typical log viewer. Maybe you need a different view type then.

I'm struggling to think of comparable content where this behavior doesn't work or at least isn't expected behavior. It works in just about any other log viewer, any database viewer, almost any commercial firewall for advanced users, it works in Excel ... pretty much everywhere where there is that type of content for the user to see an interact with.

Most debuggers allow plain text selection in their log, like Chrome for example which has an almost identical request log built in:

http://i.imgur.com/9YVg6ph.png

That would be perfectly fine as well, maybe better.
 

Blaz

Moderator & Translator
Staff member
Moderator
Context menu to copy is a hassle for me. Will stays at old version until it is fixed to get old version back.
 

Blaz

Moderator & Translator
Staff member
Moderator
To summarize what I don't like about the new filtering log:

a) too cluttered/bloated (biggest issue for me)
b) was not able to resize the new right side pane
c) shows information which I don't require like header/$$ rules
d) additional clicks are required to just copy parts of the urls (previously only one click and highlighting, now two clicks and then highlighting either in browser or unblock/block window
e) it doesn't show in which filter list the rule is which blocks/whitelist the url on the first window, I have to move the cursor on the question mark
f) when viewing a request I don't see the blocked/whitelist rule of other requests until I close the new pane or click on the next request
g) a blocked request by a generic rule was only displayed as _my_ad_integration and I couldn't find the url

Suggestion: Two view modes, simple mode (previous look) and advanced mode (new look)
 
Last edited:

avatar

Administrator
Staff member
Administrator
Suggestion: Two view modes, simple mode (previous look) and advanced mode (new look)
This is the easiest solution, but it is absolutely worst if we want to improve the filtering log instead of sticking to the old version. Moreover, if we want to make it better, we especially need your advice, and we will get nothing if you continue using the old one.

a) too cluttered/bloated (biggest issue for me)
That's why there are different tabs and most of the information is on the "network" tab.

Do you find the "General" tab bloated?

b) was not able to resize the new right side pane
We'll check what can be done about it.
https://github.com/AdguardTeam/AdguardForWindows/issues/1675

c) shows information which I don't require like header/$$ rules
HTTP headers information might be crucial sometimes. For instance, it might be useful to see what Cookies are set by the websites. Or when you're dealing with a redirecting (location or refresh headers). Anyways, headers information is located on the network tab, which is not selected by default.

What for $$ rules, are you sure you don't need to see what was actually removed from the webpage?

d) additional clicks are required to just copy parts of the urls (previously only one click and highlighting, now two clicks and then highlighting either in browser or unblock/block window
Yeah, we will address it in the first place.

e) it doesn't show in which filter list the rule is which blocks/whitelist the url on the first window, I have to move the cursor on the question mark
Here is what I suggest:
https://github.com/AdguardTeam/AdguardForWindows/issues/1676

f) when viewing a request I don't see the blocked/whitelist rule of other requests until I close the new pane or click on the next request
I must admit, there's not much we can do with this.

Suggestion: close the details pane on the second click on the selected record. This should make navigation a bit easier.

g) a blocked request by a generic rule was only displayed as _my_ad_integration and I couldn't find the url
Could you please explain? I didn't get it.
 

Blaz

Moderator & Translator
Staff member
Moderator
a)
The general tab should be as clean as possible, I don't need network/cookies view.

c) For cookies view I have a tab in my Chrome where I also can check for Local/Session Storage. The $$ rules were perfectly shown in the old view.
Redirects already show as a new URL HTML request and are usually followed after the request which did it.

f) I don't need the details panel at all, I only need the following information:
Request URL
Source
Applied rules and from which filter list they come from
Media Type

To cut short, the old layout is clean and for me enough.

g)
I checked the site at https://forum.adguard.com/index.php?threads/resolved-sportdeutschland-tv-cdn-livetvcdn-net-ad-blocker-detected.9777/#post-132836 and when I checked the log it was only showing the rule generic block rule for "_my_ad_integration", but not the path of it.
The old view displayed the blocked the url and the responsible rule for it in brackets.

Why not just leave the old layout and have an option which shows the other information.
So one would see the listed elements of f) and have a button like "Details" for network/cookies view and one button for block/unblock.

Currently the new layout is not usable for me at all (mainly due to a)
 

avatar

Administrator
Staff member
Administrator
c) For cookies view I have a tab in my Chrome where I also can check for Local/Session Storage.
This!

We want to make it possible to not use your browser's developer tools at all. Filtering log should be sufficient to make a decision. Why are we doing it? Because Adguard is supposed to work for all browsers and all apps, not just for those browsers with convenient dev tools like Chrome/FF. For instance, with the old version, it was almost impossible to understand anything about in-apps ads & tracking because we didn't see any details of the requests. The same issue arose when we tried to do a small research on Windows telemetry and what can be done about it.

Tomorrow I'll comment on the other points, need to get some sleep now.
 

Blaz

Moderator & Translator
Staff member
Moderator
We want to make it possible to not use your browser's developer tools at all.
That will be not possible due to Javascript/Replace rules and Adguard Assistant is sometimes clicking the ad and not selecting it (at least the last time I used it, was about 1,5 or more years ago).
Also if you want to see the cookies in filtering log, then it should be possible to highlight/modify/add cookies there on-the-fly.


Have a good sleep.
 

avatar

Administrator
Staff member
Administrator
What I don't understand is why don't you use the new Block/Unblock dialogs to create filtering rules?
They are supposed to be enough for creating 99% filtering rules.

From what I understand, when we add a log record context menu it should cover all your needs:
https://monosnap.com/file/B6KuNT5F4TMGmbHYfNvq8KWcwV2Ort

What am I missing here?

The general tab should be as clean as possible, I don't need network/cookies view.
f) I don't need the details panel at all, I only need the following information:
I am pretty sure the process information might come in handy as request could've arrived from another app/browser.

Connection ID -- let's move it to the network tab then.
Not sure about timing and size, though. I guess we can move it to the network tab as well.

This will make "General" tab pretty clean, even rather "empty".

Thoughts?

Why not just leave the old layout and have an option which shows the other information.
So one would see the listed elements of f) and have a button like "Details" for network/cookies view and one button for block/unblock.
Details button wouldn't work as others, for instance, prefer to have details pane instead of the old view. So the only way would be to have a checkbox or something like that, and that will mean that we should support two completely different detail views in the filtering log, and that's what I want to avoid.

Ideally, I'd like all the issues with the new view to be sorted out, so that everybody was happy.

That will be not possible due to Javascript/Replace rules and Adguard Assistant is sometimes clicking the ad and not selecting it (at least the last time I used it, was about 1,5 or more years ago).
I realize that we cannot completely replace the dev tools, but we should make it as close as possible.
 

Blaz

Moderator & Translator
Staff member
Moderator
What I don't understand is why don't you use the new Block/Unblock dialogs to create filtering rules?
They are supposed to be enough for creating 99% filtering rules.
I don't like help from assistants and I'm used to write the rules by hand. Also when I want to add specific block rules for urls which are already blocked by a generic rule that assistant is not working.


So the only way would be to have a checkbox or something like that, and that will mean that we should support two completely different detail views in the filtering log, and that's what I want to avoid.
That would be the easiest method and the best way to satisfy the users who want more details and minimalists like me who only require the most basic information of a request and want a simple, not cluttered/bloated interface.
We had the good old simple filtering log for years and it worked very fine. Why break something simple?
 
Status
Not open for further replies.
Top