Installing AdGuard From GitHub to Support JS Rules?

Discussion in 'AdGuard for Firefox' started by Cascade, Apr 18, 2018.

  1. Cascade

    Cascade New Member

    Joined:
    Oct 7, 2017
    Messages:
    43
    Hi,

    Currently, I use AdGuard Firefox extension on a Windows 7 PC (running Firefox 59.0.2), which was installed from AMO. I understand that this AMO version does not support JS rules from filter updates and that a version can be downloaded from GitHub here that supports these JS rules on Firefox:

    https://github.com/AdguardTeam/AdguardBrowserExtension/releases/

    Just a few quick questions:

    1) Which file do I need to install for the release (non-beta) AdGuard version?

    2) Do I need to uninstall the version from AMO first?

    3) Will the version from GitHub auto update to the next release version on GitHub?

    4) Will settings be preserved from the AMO version?

    5) Why does the AMO version support these JS rules in user filters but not downloaded filters? I wouldn't think it would make any difference where the JS rule is added but apparently it does.

    Thanks.
     
  2. vasily_bagirov

    vasily_bagirov Administrator Staff Member Administrator

    Joined:
    Jul 1, 2014
    Messages:
    6,905
    firefox-amo-release-2.9.2-unsigned.zip will give you a lot of headache, as it is unsigned. You can install firefox-standalone-beta-2.9.2.xpi but it will use beta update channel. You can't really install the release AG extension from GitHub.

    No, if I'm not mistaken.

    Yes it will use beta update channel.

    No, but you can import the user filter.

    Hm where did you read this? I don't recall anything about it.
     
  3. Cascade

    Cascade New Member

    Joined:
    Oct 7, 2017
    Messages:
    43
    Thanks for your reply.

    I think I will stick with the Firefox AMO version for now as I prefer to be on the release version, instead of the beta version.

    I can work around the issue by using Chrome instead of Firefox for affected sites.

    It would be great if these JS rules could be supported in Firefox AMO in the future. I've been caught out a few times with this issue and it isn't something that is particularly obvious from the end user's point of view.

    Regarding my last point, here are a couple of instances where I have been advised to add a JS rule that is already in a downloaded filter to my custom (user) filter, to make the rule work:

    https://forum.adguard.com/index.php?threads/resolved-olpair-com.26090/
    https://github.com/AdguardTeam/AdguardFilters/issues/14571

    Is this correct?
     
  4. Blaz

    Blaz Moderator & Translator Staff Member Moderator

    Joined:
    Dec 21, 2014
    Messages:
    9,751
    It is a restriction by Mozilla and Opera to not allow javascript rule updates from filter lists.

    It works in user filter as there is no such restriction there.
     
  5. Cascade

    Cascade New Member

    Joined:
    Oct 7, 2017
    Messages:
    43
    Thanks for confirming. :)